LACP upgrade - 13: cleaning up LAG module

Cleaned up #LAG and #LACP modules with #miscellaneous #changes. Corrected the #PDU #handler in LACP module. Reordered PDU buffer data-structure. Removed definitions of the old module data-structures in LAG module. Corrected #aggregator #member-port #list iterator routine. Corrected #member-port #statistics iterator routines with direct references from member-port configuration entries. Updated #custom #aggregator configuration entries with direct reference from the aggregator configuration entries.

#LACP update 26 ...
[commit a64084632d865d7e2dbbbe553d7bc4d64f4bea43] (https://github.com/nes-repo/NES-Open-Switch/commit/a64084632d865d7e2dbbbe553d7bc4d64f4bea43)

LACP upgrade - 12: updating member port selection handler

Updated #member-port #selection #handler in #LACP module. This handler checks and #verifies whether the #peer #partner and the #peer #port #attributes are not changing. The peer port info is recorded while LACP PDU is received. While there is an #administrative #configuration change from the peer side or a #physical #connectivity #changes happens from the remote side, it has to be decided whether the #member-port can still be part of #aggregation or not. The handler reads out the attributes passed in the LACP PDU and compare them against the peer port info recorded earlier. When the attributes differ in the PDU the member-port is marked as not part of the aggregation and #member-port #selection #procedures are executed.

#LACP update 25 ...
[commit d9276967f49544b9bdec8921911edf9f52286aa3] (https://github.com/nes-repo/NES-Open-Switch/commit/d9276967f49544b9bdec8921911edf9f52286aa3)

LACP upgrade - 11: updating member port distribution and collection handler

Updated #distribution and #collection #handler for #member-ports in #LACP module. The handler #enables the collection and distribution operations #sequentially on each port. After an #aggregator port is selected to be #attached with the member port member port moves to the #synchronized #state with the peer port. i.e. both peer agrees that same aggregator link is used for attaching from both peer systems. Once the synchronization is attained the handler #enables #collection operation on the member port and the #HAL #calls will be done for enabling collecting operation in the #hardware as well. Once this is done, informs the peer about this with an updated LACP PDU. Once both the peers are collecting data from each side of the link for the same aggregator port the #distribution operation will be started on the member port by the handler in the next step. The #HAL call will be done and the updated LACP PDU will be sent to peer to inform them as well. Once both collection and distribution operations are enabled on the member ports the link will be fully participating in the aggregation operation.

#LACP update 24 ...
[commit 10442a8c8cd0bf6e7bba44a62cf01c3fda3a99d3] (https://github.com/nes-repo/NES-Open-Switch/commit/10442a8c8cd0bf6e7bba44a62cf01c3fda3a99d3)

LACP upgrade - 4: updated LACP member port detach handler

Updated #member-port #detach #handler in #LACP module. This handler #detaches the #port from the #hardware #aggregator and #inform the #remote #peer of the same. After this a wait timer is set for later processing. This procedure is executed as part of #protocol #state #changes or as a side effect of a management operation. The aggregator is detached from the member-port in hardware and the peer is informed that local end is not in sync anymore. The #collection and #distribution procedures are #disabled in #hardware and the peer will be known of the same when it receives the updated LACP PDU from local end.

#LACP update 17 ...
[commit 246b3ed5760ddcf5cf0765586213084eff6fd177] (https://github.com/nes-repo/NES-Open-Switch/commit/246b3ed5760ddcf5cf0765586213084eff6fd177)

LACP upgrade - 3: updated LACP member port initialization and reset routines

Updated #member-port #init and #reset routines in #LACP module. These routine the initialization and reset operation as part of the #LACP #protocol #operation. On init for the member-port the LAG initialization routine is also called for setting defaults for the LAG parameters. The init also causes the #member-port to be #detached from the #aggregator as well. Hence the selection process starts over again and #elects the #aggregator again.

#LACP update 16 ...
[commit 1a5e11fea1f11448ca06d1e44b62971268b366d3] (https://github.com/nes-repo/NES-Open-Switch/commit/1a5e11fea1f11448ca06d1e44b62971268b366d3)

LACP upgrade - 1: updated LACP aggregator and member port activation handler

Updated the port status #activation #handler for both #aggregator and the #member-port in #LACP module. The data type references has been corrected to use the new updated type. The activation handlers #cascade the #configuration #state #changes from the #LAG module to LACP module. On moving the port to #active state from LAG module, the #LACP #protocol specific procedures will be #started for these ports. Similarly on putting these ports in to #not-in-service or #not-ready state, the #protocol procedures are #stopped and #cleanup is done for these ports.

#LACP update 14 ...
[commit d726911bd75d0e80a7a65e4274f06bde3c4fc806] (https://github.com/nes-repo/NES-Open-Switch/commit/d726911bd75d0e80a7a65e4274f06bde3c4fc806)